fix(auth): adds missing EMAIL_NOT_FOUND error code #550
Conversation
Catch EMAIL_NOT_FOUND and translate to EmailNotFoundError when /accounts:sendOobCode is called for password reset on a user that does not exist.
There was a problem hiding this comment.
Thank you @bojeil-google !
LGTM. Please add a TW to review the reference doc changes.
There was a problem hiding this comment.
One possible typo. Can we also add a test case? Similar to:
firebase-admin-python/tests/test_user_mgt.py
Line 286 in ebf0961
firebase_admin/_auth_client.py
Outdated
| @@ -464,6 +465,7 @@ def generate_email_verification_link(self, email, action_code_settings=None): | |||
|
|
|||
| Raises: | |||
| ValueError: If the provided arguments are invalid | |||
| UserNotFoundError: If no user exists by the specified email address. | |||
There was a problem hiding this comment.
Should be EmailNotFoundError?
There was a problem hiding this comment.
Unfortunately, this is the problem. They throw different errors. For password reset, they throw EMAIL_NOT_FOUND. For email verification, they throw USER_NOT_FOUND.
Done |
firebase_admin/_auth_client.py
Outdated
| @@ -444,6 +444,7 @@ def generate_password_reset_link(self, email, action_code_settings=None): | |||
|
|
|||
| Raises: | |||
| ValueError: If the provided arguments are invalid | |||
| EmailNotFoundError: If no user exists by the specified email address. | |||
There was a problem hiding this comment.
Is there a specific reason to use "by" here?
I'd expect "for" probably, here and below.
There was a problem hiding this comment.
Thanks for catching. I copied and pasted blindly. It is fixed now here and elsewhere.
Catch EMAIL_NOT_FOUND and translate to EmailNotFoundError when /accounts:sendOobCode is called for password reset on a user that does not exist.